Re: Removing -Wunsuffixed-float-constants, -Wdouble-promotion, -Wformat-zero-length

[Simon Josefsson]

Paul Eggert <address@hidden> writes:

> On 11/29/11 09:35, Jim Meyering wrote:
>> +  gl_WARN_ADD([-Wno-unsuffixed-float-constants])
>
> How about if we remove -Wunsuffixed-float-constants from
> manywarnings.m4?  In practice it typically causes more
> trouble than it cures (the above-quoted gzip patch is
> one example, but I've run into it elsewhere).
>
> While we're on the subject of manywarnings.m4, can we also
> remove -Wdouble-promotion and -Wformat-zero-length?  They
> also seem to be more suited for special- rather than
> general-purpose code.

I'm opposed to this -- the philosophy behind the manywarnings module is
to enable all possible kind of warnings that you can get from gcc and
then each project has to disable the warnings that they decide are not
worth fixing.  That decision has to be different for each project.  I
believe this is fairly well described in doc/manywarnings.texi.

I'm not opposed to create a somewarnings.m4 or similar that filters out
some warnings, if you would find that useful.

FWIW, I have not had to disable the above flags in any of my projects,
and I would want to be informed if I introduce new code that triggers
them.

/Simon