bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] init.sh: avoid unwarranted test failure when using "set -x"


From: Pádraig Brady
Subject: Re: [PATCH] init.sh: avoid unwarranted test failure when using "set -x"
Date: Thu, 22 Dec 2011 11:58:04 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0

On 12/22/2011 11:44 AM, Jim Meyering wrote:
> FYI, after updating to the latest tests/init.sh, I noticed new
> failures in vc-dwim's "make check".  Tracked it down to this:
> 

> diff --git a/tests/init.sh b/tests/init.sh
> index 19c0cf4..458a448 100644
> --- a/tests/init.sh
> +++ b/tests/init.sh
> @@ -304,7 +304,7 @@ fi
>  # Otherwise, propagate $? to caller: any diffs have already been printed.
>  compare ()
>  {
> -  compare_dev_null_ "$@"
> +  compare_dev_null_ "$@" || :
>    case $? in
>      0|1) return $?;;
>      *) compare_ "$@";;

Doesn't that just always set $? to 0
What am I missing?

cheers,
Pádraig.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]