bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] init.sh: new module, and add minimal tests of its compare fu


From: Bruno Haible
Subject: Re: [PATCH] init.sh: new module, and add minimal tests of its compare function
Date: Tue, 03 Jan 2012 03:09:05 +0100
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

Hi Jim,

> * tests/test-init.sh: New file.

This test fails on some platforms:

On Solaris 7, HP-UX 11.00, IRIX 6.5:

test-init.sh: failed test: err not empty: Can't open --
FAIL: test-init.sh

On FreeBSD 6.4:

test-init.sh: failed test: err not empty: sed: --: No such file or directory
PASS: test-init.sh

On OpenBSD 4.9:

--- exp Tue Jan  3 01:53:17 2012
+++ out Tue Jan  3 01:53:17 2012
@@ -1,4 +1,3 @@
 diff -u /dev/null in
 --- /dev/null  1970-01-01
 +++ in 1970-01-01
-+xyz
test-init.sh: failed test: err not empty: sed: --: No such file or directory
FAIL: test-init.sh

On NetBSD 5.1:

--- exp 2012-01-03 02:51:58.000000000 +0100
+++ out 2012-01-03 02:51:58.000000000 +0100
@@ -1,4 +1,3 @@
 diff -u /dev/null in
 --- /dev/null  1970-01-01
 +++ in 1970-01-01
-+xyz
test-init.sh: failed test: err not empty: sed: --: No such file or directory
FAIL: test-init.sh


The use of '--' in tests/init.sh:compare_dev_null_ was probably meant to
protect against a file name that starts with a minus sign. But is that
a realistic expectation in a test suite?

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]