[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Don't use the abbreviation "win" to refer to Windows.

From: Paolo Bonzini
Subject: Re: Don't use the abbreviation "win" to refer to Windows.
Date: Tue, 03 Jan 2012 20:30:41 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:9.0) Gecko/20111222 Thunderbird/9.0

On 01/02/2012 11:57 PM, Paul Eggert wrote:
Anyway, impressing people is not the main goal here.
The main goal is to come up with a useful name that
doesn't praise the Windows API or operating environment.
"win32" is not the right choice for that, we must use
something better, and there is a proposal on the table.

Anybody whose intelligence is enough to understand the gnulib code will understand that "win32" is an abbreviation of "Windows 32".

Please do not use "woe32" in code, use "w32" throughout. Patch is _not_ approved for lib/poll.c and lib/select.c


* lib/progreloc.c, tests/test-poll.c, tests/test-select.h:
(WOE32_NATIVE): Rename from WIN32_NATIVE.

 #if defined _WIN32 || defined __WIN32__
-# define WIN32_NATIVE
+# define WOE32_NATIVE

Great example of consistency. Too bad you cannot rename the pre-defined #defines. Want to open a bug against GCC?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]