[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] init.sh: don't waste a subshell just to redirect stderr

From: Stefano Lattarini
Subject: Re: [PATCH] init.sh: don't waste a subshell just to redirect stderr
Date: Thu, 05 Jan 2012 18:49:55 +0100

On 01/05/2012 05:56 PM, Bruno Haible wrote:
> Eric Blake replied:
>>> Wouldn't it be simpler and better to leave that redirection out altogether?
>>> The output of the test scripts should be redirected to `.log' files by the
>>> testsuite harness, so by being more verbose we can make those files more
>>> informative, all without cluttering the make output.
>> In the case of coreutils, yes.  But in the case of ./gnulib-tool
>> --with-tests --test ..., for running gnulib unit tests, there is nothing
>> capturing the stderr, so it leaks to the output.
Ah, right, the gnulib-generated Makefile.am files have to work also with
automake 1.10 and 1.9, so they can't blindly emit add `parallel-tests' to

> Yes, and gettext and other packages also run gnulib unit tests.
> Automake offers several flavours of the testsuite framework. Gnulib's
> tests should work reasonably with all of them.
Note that this objection is subtly wrong.  If gnulib could assume Automake 1.11,
it could simply add the `parallel-tests' option to AUTOMAKE_OPTIONS in the
gnulib-controlled Makefile.am.  This setting would only influence the execution
of the test cases provided by gnulib itself, and wouldn't have any impact on the
"global" testsuite framework used by the package.  It would be a win-win 
for once.   But this is all moot, since gnulib can't assume Automake 1.11 (yet).
Oh well.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]