bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

gnulib-tool recommendations don't honour command line flags


From: Werner LEMBERG
Subject: gnulib-tool recommendations don't honour command line flags
Date: Sun, 08 Jan 2012 14:38:06 +0100 (CET)

[gnulib commit 60224129]

I've invoked gnulib-tool as follows:

  gnulib-tool --import \
              --m4-base=gnulib/m4 \
              --source-base=gnulib/src \
              --aux-dir=gnulib getopt-gnu

and the recommendations emitted say this:

  Don't forget to
    - add "lib/Makefile" to AC_CONFIG_FILES in ./configure.ac,
    - mention "lib" in SUBDIRS in Makefile.am,
    - mention "-I m4" in ACLOCAL_AMFLAGS in Makefile.am,
    - mention "m4/gnulib-cache.m4" in EXTRA_DIST in Makefile.am,
    - invoke gl_EARLY in ./configure.ac, right after AC_PROG_CC,
    - invoke gl_INIT in ./configure.ac.

However, this should rather be

  Don't forget to
    - add "gnulib/src/Makefile" to AC_CONFIG_FILES in ./configure.ac,
    - mention "gnulib/src" in SUBDIRS in Makefile.am,
    - mention "-I gnulib/m4" in ACLOCAL_AMFLAGS in Makefile.am,
    - mention "gnulib/m4/gnulib-cache.m4" in EXTRA_DIST in Makefile.am,
    - invoke gl_EARLY in ./configure.ac, right after AC_PROG_CC,
    - invoke gl_INIT in ./configure.ac.

Actually, I suggest two additions so that we have

  Don't forget to
    - add "gnulib/src/Makefile" to AC_CONFIG_FILES in ./configure.ac,
    - add "gnulib/m4" to AC_CONFIG_MACRO_DIR in ./configure.ac
    - mention "gnulib/src" in SUBDIRS in Makefile.am,
    - mention "-I gnulib/m4" in ACLOCAL_AMFLAGS in Makefile.am
      (use a single line for all include directives),
    - mention "gnulib/m4/gnulib-cache.m4" in EXTRA_DIST in Makefile.am,
    - invoke gl_EARLY in ./configure.ac, right after AC_PROG_CC,
    - invoke gl_INIT in ./configure.ac.
    

      Werner



reply via email to

[Prev in Thread] Current Thread [Next in Thread]