Re: Moving the gnupload script from automake to gnulib?

[Jim Meyering]

Stefano Lattarini wrote:
> Hi Jim, thanks for the quick reply.
...
> Attached is the proposed patch.  I will push as soon as I have an ACK.
...
> +2011-01-15  Stefano Lattarini  <address@hidden>
> +
> +     gnupload: we hold the master copy of this script now
> +     For motivation and more information, see:
> +     <http://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00222.html>
> +     * build-aux/gnupload: Make it clear in the heading comments that the
> +     master copy of this file is maintained by gnulib.  Since we are at
> +     it, bump its copyright year and ...
> +     ($scriptversion): ... the date in its version.
> +     ($usage): Patches and bug reports should be sent to the gnulib list,
> +     not the automake one.
> +     * config/srclist.txt: Don't try to sync 'gnupload' from automake
> +     anymore.
> +
>  2012-01-15  Bruno Haible  <address@hidden>
>
>       Fix module 'random'.
> diff --git a/build-aux/gnupload b/build-aux/gnupload
> index 209f875..cd80257 100755
> --- a/build-aux/gnupload
> +++ b/build-aux/gnupload
> @@ -1,10 +1,10 @@
>  #!/bin/sh
>  # Sign files and upload them.
>
> -scriptversion=2010-05-23.15; # UTC
> +scriptversion=2012-01-15.15; # UTC
>
> -# Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Free Software
> -# Foundation, Inc.
> +# Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Free
> +# Software Foundation, Inc.

Might as well list 2004-2010 as a range.
Then it fits on one line:

  # Copyright (C) 2004-2010, 2012 Free Software Foundation, Inc.

>  # This program is free software; you can redistribute it and/or modify
>  # it under the terms of the GNU General Public License as published by
> @@ -20,6 +20,8 @@ scriptversion=2010-05-23.15; # UTC
>  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>
>  # Originally written by Alexandre Duret-Lutz <address@hidden>.
> +# The master copy of this file is maintained in the gnulib Git repository.
> +# Please send bug reports and feature requests to address@hidden
>
>  set -e
>
> @@ -57,7 +59,7 @@ Options:
>    --version                output version information and exit
>
>  If --symlink-regex is given without EXPR, then the link target name
> -is created by replacing the version information with '-latest', e.g.:
> +is created by replacing the version information with \`-latest', e.g.:

By this (and others like it) aren't you reverting recent quoting changes
that were made in gnulib?

Otherwise, it looks fine.