[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Feature request] gitlog-to-changelog: don't cluster multiple Change

From: Jim Meyering
Subject: Re: [Feature request] gitlog-to-changelog: don't cluster multiple ChangeLog entries under the same "date line"
Date: Tue, 17 Jan 2012 22:48:15 +0100

Joel E. Denny wrote:
> On Mon, 26 Dec 2011, Jim Meyering wrote:
>> I think the result is an improvement, but it is still not as readable as I
>> would like, or maybe it's just not as readable as I am used to ("git log"
>> output).  Why? ...  Because when some clumped entries are adjacent to a
>> multi-paragraph one, the style dichotomy makes it a little harder to see
>> that each of the clumped entries does indeed correspond to its own commit.
>> What I guess I'm saying is that I see your point of view.
>> If you ever write the patch you want, with some new option,
>> I'll probably apply it here.
> Below is a patch that adds a --no-cluster option, which I believe does
> what Stefano wants.  I want it too.  OK to push?

Hi Joel,

Thanks.  That looks fine, but please adjust the preceding comment
to keep in sync with the new behavior.

> @@ -305,7 +311,8 @@ sub parse_amend_file($)
>        # If this header would be different from the previous date/name/email/
>        # coauthors header, or if this or the previous entry consists of two
>        # or more paragraphs, then print the header.
> -      if ($date_line ne $prev_date_line
> +      if ($no_cluster
> +          or $date_line ne $prev_date_line
>            or "@coauthors" ne "@prev_coauthors"
>            or $multi_paragraph
>            or $prev_multi_paragraph)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]