Re: [PATCH gnulib 2/4] accept4, fcntl, w32sock: Avoid warnings on x86_64 mingw64.

[Bruno Haible]

Marc-André Lureau wrote:
>  2012-01-24  Marc-André Lureau  <address@hidden>
>  
> +     accept4, fcntl, w32sock: Avoid warnings on x86_64 mingw64.
> +     * lib/accept4.c (accept4): _open_osfhandle() expect a
> +     intptr_t.
> +     * lib/fcntl.c (dupfd): Likewise.
> +     * lib/w32sock.h (SOCKET_TO_FD): Likewise.

Thanks. I have verified that the argument type of _open_osfhandle() is
'long' only in the primary mingw and is 'intptr_t' in MSVC9 and mingw64,
and that your change does not need a #include <stdint.h> (since the
use of intptr_t is limited to native Windows platforms).

Applied with a slightly modified ChangeLog entry. A ChangeLog entry should
mention the change that was done; just mentioning a fact or rationale without
mentioning the change can be confusing.

Bruno


2012-01-28  Marc-André Lureau  <address@hidden>  (tiny change)

        accept4, fcntl, socket modules: Avoid warnings on x86_64 mingw64.
        * lib/accept4.c (accept4): Use intptr_t to convert handle pointer to
        an integer.
        * lib/fcntl.c (dupfd): Likewise.
        * lib/w32sock.h (SOCKET_TO_FD): Likewise.