bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] strtoimax: eliminate need for stdint.h, inttypes.h checks


From: Bruno Haible
Subject: Re: [PATCH] strtoimax: eliminate need for stdint.h, inttypes.h checks
Date: Sat, 28 Jan 2012 23:59:13 +0100
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

Hi Paul,

> This reduces the prerequisites for a recently-introduced strtoimax test.
> I guess this might cause strtoimax to be replaced when not
> strictly necessary on older hosts, but this shouldn't introduce
> any bugs and it should make Emacs 'configure' faster on typical
> modern hosts.

This is a strange argumentation. Up to now, we have always minimized
the code size, even if it costs some .m4 macros to run at configure
time. If we start introducing code in .o files because it can save
some 0.5 seconds of configure time, we are dropping one of the main
promises of gnulib:
  - It perfectly adapts to the target platform.
  - It does not create unnecessary code in .o files ("bloat").

>    if test $ac_cv_func_strtoimax = yes; then

This test evaluates to true on
  glibc, MacOS X, FreeBSD, NetBSD,
  AIX >= 5.1, HP-UX >= 11.23, Solaris >= 10, Cygwin, mingw, BeOS.

>      dnl On AIX 5.1, strtoimax() fails for values outside the 'int' range.

The objective of the test is to make it fail on AIX 5.1. I test the
effect of your patch on these platforms, and it turns out you have an
unfair amount of luck (or karma :-) ): it causes no deterioration on
any of the platforms!

  $ grep 'strtoimax works' *.log
  aix51-cc.log:checking whether strtoimax works... no
  aix52-cc.log:checking whether strtoimax works... yes
  aix53-cc.log:checking whether strtoimax works... yes
  aix61-cc.log:checking whether strtoimax works... yes
  aix71-cc.log:checking whether strtoimax works... yes
  cygwin15.log:checking whether strtoimax works... yes
  cygwin1.7.5.log:checking whether strtoimax works... yes
  cygwin1.7.9.log:checking whether strtoimax works... yes
  freebsd64.log:checking whether strtoimax works... yes
  hpux11.23.log:checking whether strtoimax works... yes
  hpux11.31.log:checking whether strtoimax works... yes
  linux.log:checking whether strtoimax works... yes
  macosx.log:checking whether strtoimax works... yes
  mingw2009.log:checking whether strtoimax works... yes
  netbsd51.log:checking whether strtoimax works... yes
  solaris10-cc.log:checking whether strtoimax works... yes
  solaris11x8632.log:checking whether strtoimax works... yes

Bruno




reply via email to

[Prev in Thread] Current Thread [Next in Thread]