[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: quotearg test

From: Bruno Haible
Subject: Re: quotearg test
Date: Mon, 30 Jan 2012 20:46:06 +0100
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

Hi Eric,

> > 2012-01-28  Bruno Haible  <address@hidden>
> > 
> >     quotearg: Fix test failure on MacOS X 10.5.
> >     * tests/test-quotearg-simple.c: Include localcharset.h.
> >     (main): If the locale encoding is not ASCII, bypass the tests of
> >     locale_quoting_style and clocale_quoting_style.
> I'm fine with applying this, as it is an improvement

OK, I've applied it.

> even if it is not as drastic as your overall idea for rewriting the test.

Of course I wanted to hear your opinion before doing a rewrite.

> > Concretely, this would mean
> >   - keep the function compare(),
> >   - change the function compare_strings to take 9 individual arguments
> >     instead of a 'struct result_strings *',
> >   - split it into two functions, one that corresponds to the case
> >     ascii_only==true, one for the case ascii_only==false.
> >   - in main(), invert the scope of the loops over the styles and over
> >     the data: Put the loop over different data elements outside the loop
> >     over the styles; otherwise it is impossible to add extra data only
> >     for one style but not for the others.
> Is that a patch you are willing to write, or are you asking me to do
> this work?  If the latter, then I will try to get to it this week.

I could do it as well (at a low priority). Of course, since I have so many
other things on my plate, I prefer if you could do it.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]