bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint.mk: also prohibit lower-case @var@


From: Eric Blake
Subject: Re: [PATCH] maint.mk: also prohibit lower-case @var@
Date: Tue, 07 Feb 2012 10:31:55 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0

On 02/03/2012 12:27 AM, Jim Meyering wrote:
> Eric Blake wrote:
>> * top/maint.mk (sc_makefile_at_at_check): Enhance check to cover
>> lower case, like @address@hidden
>>
>> Signed-off-by: Eric Blake <address@hidden>
>> ---
>>
>> Any objections to this?  I noticed that libvirt had a mix
>> of $(top_srcdir) and @top_srcdir@ in the same variable, and
>> traced it to a weak syntax check not catching the difference.
> 
> No objection.  I vaguely recall deliberately omitting lower case
> variables (maybe even for libvirt), to make the check less invasive.
> 
> But please adjust it to use /.../i instead of adding a-z.
> Better still, just use \w+ instead of the explicit [...]+.

Done with that change.

>>  sc_makefile_at_at_check:
>> -    @perl -ne '/address@hidden@/'                                   \
>> -          -e ' && !/([A-Z_0-9]+)address@hidden@$$/'                 \
>> +    @perl -ne '/address@hidden@/'                                   \
>> +          -e ' && !/([A-Za-z_0-9]+)address@hidden@$$/'                      
>> \
>>            -e ''$(_makefile_at_at_check_exceptions)                  \
>>        -e 'and (print "$$ARGV:$$.: $$_"), $$m=1; END {exit !$$m}'    \
>>          $$($(VC_LIST_EXCEPT) | grep -E '(^|/)(Makefile\.am|[^/]+\.mk)$$') \
> 
> 

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]