bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] bootstrap: don't exit 0 upon gnulib-tool failure


From: Jim Meyering
Subject: [PATCH] bootstrap: don't exit 0 upon gnulib-tool failure
Date: Sat, 11 Feb 2012 11:23:06 +0100

I ran (syncsub, commit, etc.), ./bootstrap && ./configure && make in
coreutils, expecting the regcomp.c changes to cause the bootstrap to fail.
I got these diagnostics:

  gnulib/gnulib-tool: *** patch file gl/lib/regcomp.c.diff didn't apply cleanly
  gnulib/gnulib-tool: *** Stop.

but they scrolled by as configure and make ran.
Oops.  Here's the fix:

>From de009b65198c00dbe0ecd796ce75d5d9f5346103 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 11 Feb 2012 10:57:28 +0100
Subject: [PATCH] bootstrap: don't exit 0 upon gnulib-tool failure

* build-aux/bootstrap (gnulib_tool): If gnulib-tool fails, exit with
its exit status, not 0.
---
 ChangeLog           |    6 ++++++
 build-aux/bootstrap |    4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 5d6a9a6..e20eb75 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-02-11  Jim Meyering  <address@hidden>
+
+       bootstrap: don't exit 0 upon gnulib-tool failure
+       * build-aux/bootstrap (gnulib_tool): If gnulib-tool fails, exit with
+       its exit status, not 0.
+
 2011-12-19  Reuben Thomas  <address@hidden>

        README-release: various improvements
diff --git a/build-aux/bootstrap b/build-aux/bootstrap
index 6910abf..c8ee3cc 100755
--- a/build-aux/bootstrap
+++ b/build-aux/bootstrap
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Print a version string.
-scriptversion=2012-01-21.16; # UTC
+scriptversion=2012-02-11.09; # UTC

 # Bootstrap this package from checked-out sources.

@@ -604,7 +604,7 @@ if $bootstrap_sync; then
 fi

 gnulib_tool=$GNULIB_SRCDIR/gnulib-tool
-<$gnulib_tool || exit
+<$gnulib_tool || exit $?

 # Get translations.

--
1.7.9.190.gf1d33



reply via email to

[Prev in Thread] Current Thread [Next in Thread]