[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] GNUmakefile: simplify detection of unconfigured trees
From: |
Eric Blake |
Subject: |
Re: [PATCH] GNUmakefile: simplify detection of unconfigured trees |
Date: |
Thu, 16 Feb 2012 13:24:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20120131 Thunderbird/10.0 |
On 02/16/2012 01:17 PM, Stefano Lattarini wrote:
>>> +_gl-Makefile := $(wildcard [M]akefile)
>>
>> According to 'info make', both 'makefile' and 'Makefile' serve as
>> defaults, so I'd rather see this as $(wildcard [mM]akefile).
>>
> This would be theoretically more correct, true, but honestly I've never
> seen a client project of gnulib (nor of the autotools for that matter)
> that uses 'makefile' instead of 'Makefile'. More importantly, this change
> of mine is meant not to entail any semantic change, so I'd rather see
> your proposed improvement implemented in a follow-up. Does that sounds
> OK to you?
You made a good point - gnulib requires automake, and automake generates
Makefile, not makefile, so checking for makefile would only help
portability to anyone who has hand-picked GNUmakefile from gnulib but is
not using gnulib proper (at which point, they can make the change to [m]
themselves). Checking for just [M]akefile should be fine, after all.
Besides, on a case-insensitive system, would [mM]akefile expand to one
name or two, considering that only one file is present but
case-insensitively matches both options (although it shouldn't matter to
our usage in the next line)?
>
>>> +ifneq ($(_gl-Makefile),)
>>
>> But it's a cool simplification. You've got my ACK.
>>
> Thanks. I will anyway wait until tomorrow before pushing, to give the
> others some more time to chime in.
Fine by me if you want to wait for a bit more review.
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature