[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fatal-signal: Fix signatures
From: |
Bruno Haible |
Subject: |
Re: fatal-signal: Fix signatures |
Date: |
Sun, 19 Feb 2012 14:29:37 +0100 |
User-agent: |
KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; ) |
Eric Blake wrote:
> > Subject: [PATCH] fatal-signal: use C prototypes (with explicit void).
> >
> > * lib/fatal-signal.c (uninstall_handlers, install_handlers)
> > (init_fatal_signal_set, block_fatal_signals): Fix signatures.
>
> Gnulib still requires edits to ChangeLog as part of the commit. I added
> that, and pushed.
But the warnings were pointless in the first place, as I explained in [1].
Instead of modifying the code to avoid pointless warnings, it would be more
useful to change GCC to not emit pointless warnings and instead make
"gcc -Wall" give a warning for the really dangerous situations. See [2].
Bruno
[1] http://lists.gnu.org/archive/html/bug-gnulib/2011-11/msg00278.html
[2] http://lists.gnu.org/archive/html/bug-gnulib/2011-11/msg00301.html