Re: [PATCH] tcgetsid: fix cygwin header bug

[Eric Blake]

On 02/29/2012 06:59 AM, Bruno Haible wrote:
> Hi Eric,
> 
>> Cygwin added tcgetsid in 1.7.10, but with int instead of pid_t:
>> http://cygwin.com/ml/cygwin-patches/2012-q1/msg00031.html
>> For now, since cygwin's pid_t is int, I'm not worrying about
>> correcting the return type.

> 
> Is it needed to make tests/test-termios.c compile? Then the lack of pid_t
> should be mentioned in doc/posix-headers/termios.texi.
> @item
> The type @code{pid_t} is not defined on some platforms:
> Cygwin.

This was the actual failure that clued me in to the problem; I'll update
the docs accordingly.

> 
> Is it needed for the declaration of tcgetsid? The code earlier in that
> file should cope with it:
> #if @GNULIB_TCGETSID@
> /* Get pid_t.  */
> # include <sys/types.h>
> #endif

Cygwin 1.7.9 lacked tcgetsid, so the gnulib declaration gave it with
pid_t.  Cygwin 1.7.10 added it, but with int return type; so I guess I
was seeing the failure in a project that included termios.h but did not
pull in the tcgetsid module.  CVS cygwin now has the corrected header
and return type declaration.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature