bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new snapshot available: coreutils-8.15.74-be17e3


From: Bruno Haible
Subject: Re: new snapshot available: coreutils-8.15.74-be17e3
Date: Sat, 17 Mar 2012 02:16:36 +0100
User-agent: KMail/4.7.4 (Linux/3.1.0-1.2-desktop; KDE/4.7.4; x86_64; ; )

[Removing platform-testers and the translation coordinator from the CC.]

Paul Eggert wrote:
> ... Bruno explained that this is a problem with the test cases,
> not in the code:
> 
> http://lists.gnu.org/archive/html/bug-gnulib/2012-01/msg00342.html
> 
> As far as I know nobody has had the time to fix the test cases,
> though.

Here's a sketch of a proposal to fix the testsuite with minimal overhead
(but still need to modify 85 files):

- Add to init.sh a function comparemq() that converts Unicode quotation
  marks to apostrophes in the ACTUAL argument.

- Each time when comparing the output of a program against the expected
  output, use 'comparemq' instead of 'compare'.

I have verified that this fixes the problem for the 'rm/isatty' test.


==============================================================================
--- tests/init.sh.bak   2012-02-03 10:22:06.000000000 +0100
+++ tests/init.sh       2012-03-17 02:02:26.000000000 +0100
@@ -311,6 +311,17 @@
   esac
 }
 
+# Usage: comparemq EXPECTED ACTUAL
+#
+# Compares modulo quotation characters in UTF-8 encoding.
+# EXPECTED contains apostrophes as quotes; ACTUAL may contain apostrophes
+# or Unicode quotation marks as quotes.
+comparemq ()
+{
+  sed -e "s/‘/'/g" -e "s/’/'/g" < "$2" > comparemq.tmp
+  compare "$1" comparemq.tmp
+}
+
 # An arbitrary prefix to help distinguish test directories.
 testdir_prefix_ () { printf gt; }
 
--- tests/rm/isatty.bak 2012-02-03 10:22:06.000000000 +0100
+++ tests/rm/isatty     2012-03-17 01:56:43.000000000 +0100
@@ -49,6 +49,6 @@
 # Append an 'x' and a newline.
 echo x >> out
 
-compare exp out || fail=1
+comparemq exp out || fail=1
 
 Exit $fail
==============================================================================


For reference, here's a list of the tests which fail:

FAIL: rm/cycle
FAIL: chmod/no-x
FAIL: rm/dir-no-w
FAIL: rm/dir-nonrecur
FAIL: rm/isatty
FAIL: rm/empty-name
FAIL: rm/fail-eacces
FAIL: rm/fail-eperm
FAIL: rm/interactive-always
FAIL: rm/r-1
FAIL: rm/r-2
FAIL: rm/rm1
FAIL: rm/rm2
FAIL: rm/rm3
FAIL: rm/rm5
FAIL: rm/unread2
FAIL: rm/unreadable
FAIL: rm/v-slash
FAIL: chgrp/no-x
FAIL: misc/test
FAIL: misc/seq
FAIL: misc/xstrtol
FAIL: misc/mktemp
FAIL: misc/join
FAIL: pr/pr-tests
FAIL: misc/wc-files0-from
FAIL: misc/basename
FAIL: misc/comm
FAIL: misc/csplit
FAIL: misc/factor
FAIL: misc/fmt
FAIL: misc/printf-cov
FAIL: misc/sort
FAIL: misc/sort-debug-warn
FAIL: misc/sort-files0-from
FAIL: misc/sort-merge
FAIL: split/suffix-length
FAIL: split/l-chunk
FAIL: misc/tac
FAIL: misc/tail
FAIL: misc/test-diag
FAIL: misc/tr
FAIL: misc/truncate-fail-diag
FAIL: misc/tsort
FAIL: misc/tty-eof
FAIL: misc/uniq
FAIL: chmod/c-option
FAIL: chmod/thru-dangling
FAIL: chown/deref
FAIL: chown/preserve-root
FAIL: cp/abuse
FAIL: cp/backup-is-src
FAIL: cp/cp-i
FAIL: cp/fail-perm
FAIL: cp/into-self
FAIL: cp/same-file
FAIL: cp/thru-dangling
FAIL: du/files0-from
FAIL: du/inacc-dest
FAIL: du/long-sloop
FAIL: du/no-x
FAIL: install/basic-1
FAIL: install/install-C
FAIL: ln/hard-backup
FAIL: ln/hard-to-sym
FAIL: ls/time-style-diag
FAIL: mv/backup-dir
FAIL: mv/diag
FAIL: mv/dir2dir
FAIL: mv/dup-source
FAIL: mv/force
FAIL: mv/hard-verbose
FAIL: mv/i-1
FAIL: mv/i-2
FAIL: mv/i-3
FAIL: mv/into-self
FAIL: mv/into-self-3
FAIL: mv/mv-n
FAIL: mv/perm-1
FAIL: mv/symlink-onto-hardlink
FAIL: mv/trailing-slash
FAIL: tail-2/follow-name
FAIL: touch/fail-diag
FAIL: touch/not-owner
FAIL: rm/cycle
FAIL: chmod/no-x
FAIL: rm/dir-no-w
FAIL: rm/dir-nonrecur
FAIL: rm/isatty
FAIL: rm/empty-name
FAIL: rm/fail-eacces
FAIL: rm/fail-eperm
FAIL: rm/interactive-always
FAIL: rm/r-1
FAIL: rm/r-2
FAIL: rm/rm1
FAIL: rm/rm2
FAIL: rm/rm3
FAIL: rm/rm5
FAIL: rm/unread2
FAIL: rm/unreadable
FAIL: rm/v-slash
FAIL: chgrp/no-x
FAIL: misc/test
FAIL: misc/seq
FAIL: misc/xstrtol
FAIL: misc/mktemp
FAIL: misc/join
FAIL: pr/pr-tests
FAIL: misc/wc-files0-from
FAIL: misc/basename
FAIL: misc/comm
FAIL: misc/csplit
FAIL: misc/factor
FAIL: misc/fmt
FAIL: misc/printf-cov
FAIL: misc/sort
FAIL: misc/sort-debug-warn
FAIL: misc/sort-files0-from
FAIL: misc/sort-merge
FAIL: split/suffix-length
FAIL: split/l-chunk
FAIL: misc/tac
FAIL: misc/tail
FAIL: misc/test-diag
FAIL: misc/tr
FAIL: misc/truncate-fail-diag
FAIL: misc/tsort
FAIL: misc/tty-eof
FAIL: misc/uniq
FAIL: chmod/c-option
FAIL: chmod/thru-dangling
FAIL: chown/deref
FAIL: chown/preserve-root
FAIL: cp/abuse
FAIL: cp/backup-is-src
FAIL: cp/cp-i
FAIL: cp/fail-perm
FAIL: cp/into-self
FAIL: cp/same-file
FAIL: cp/thru-dangling
FAIL: du/files0-from
FAIL: du/inacc-dest
FAIL: du/long-sloop
FAIL: du/no-x
FAIL: install/basic-1
FAIL: install/install-C
FAIL: ln/hard-backup
FAIL: ln/hard-to-sym
FAIL: ls/time-style-diag
FAIL: mv/backup-dir
FAIL: mv/diag
FAIL: mv/dir2dir
FAIL: mv/dup-source
FAIL: mv/force
FAIL: mv/hard-verbose
FAIL: mv/i-1
FAIL: mv/i-2
FAIL: mv/i-3
FAIL: mv/into-self
FAIL: mv/into-self-3
FAIL: mv/mv-n
FAIL: mv/perm-1
FAIL: mv/symlink-onto-hardlink
FAIL: mv/trailing-slash
FAIL: tail-2/follow-name
FAIL: touch/fail-diag
FAIL: touch/not-owner

If you need the complete log, you find the output of "make check" attached.

Bruno

Attachment: coreutils-8.15.74-be17e3-macosx-check.log.xz
Description: application/xz


reply via email to

[Prev in Thread] Current Thread [Next in Thread]