Re: fflush.c unused parameter

[Simon Josefsson]

Eric Blake <address@hidden> writes:

> On 03/30/2012 05:09 PM, Simon Josefsson wrote:
>> fflush.c:91: error: expected ';', ',' or ')' before '_GL_UNUSED_PARAMETER'
>> 
>> I suspect something like this is needed?
>
> Aargh, sorry for messing that up, and yes, you patch is right.  Can you
> go ahead and push it?

Done.

/Simon

>From 0e0635af0b23826911dc456bd0da40dcb19247de Mon Sep 17 00:00:00 2001
From: Simon Josefsson <address@hidden>
Date: Sat, 31 Mar 2012 09:56:55 +0200
Subject: [PATCH] fflush: Fix syntax error.

* lib/fflush.c: Include unused-parameter.h, needed for
_GL_UNUSED_PARAMETER.
* modules/fflush (Depends-on): Add snippet/unused-parameter.
---
 ChangeLog      |    7 +++++++
 lib/fflush.c   |    2 ++
 modules/fflush |   13 +++++++------
 3 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 3e21818..2f1b554 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2012-03-31  Simon Josefsson  <address@hidden>
+
+       fflush: Fix syntax error.
+       * lib/fflush.c: Include unused-parameter.h, needed for
+       _GL_UNUSED_PARAMETER.
+       * modules/fflush (Depends-on): Add snippet/unused-parameter.
+
 2012-03-30  Paul Eggert  <address@hidden>
 
        regex: pacify GCC when compiling GRUB
diff --git a/lib/fflush.c b/lib/fflush.c
index a43eea7..fa6f389 100644
--- a/lib/fflush.c
+++ b/lib/fflush.c
@@ -28,6 +28,8 @@
 
 #include "stdio-impl.h"
 
+#include "unused-parameter.h"
+
 #undef fflush
 
 
diff --git a/modules/fflush b/modules/fflush
index 16bdbb5..03b2f1d 100644
--- a/modules/fflush
+++ b/modules/fflush
@@ -8,12 +8,13 @@ m4/fflush.m4
 
 Depends-on:
 stdio
-fpurge          [test $REPLACE_FFLUSH = 1]
-ftello          [test $REPLACE_FFLUSH = 1]
-freading        [test $REPLACE_FFLUSH = 1]
-lseek           [test $REPLACE_FFLUSH = 1]
-unistd          [test $REPLACE_FFLUSH = 1]
-fseeko          [test $REPLACE_FFLUSH = 1]
+snippet/unused-parameter  [test $REPLACE_FFLUSH = 1]
+fpurge                    [test $REPLACE_FFLUSH = 1]
+ftello                    [test $REPLACE_FFLUSH = 1]
+freading                  [test $REPLACE_FFLUSH = 1]
+lseek                     [test $REPLACE_FFLUSH = 1]
+unistd                    [test $REPLACE_FFLUSH = 1]
+fseeko                    [test $REPLACE_FFLUSH = 1]
 
 configure.ac-early:
 AC_REQUIRE([AC_FUNC_FSEEKO])
-- 
1.7.2.5