Re: [PATCH, resend] Handle multibyte codepoint width properly

[Vladimir 'φ-coder/phcoder' Serbinenko]

On 05.04.2012 14:32, Bruno Haible wrote:
> Hi Vladimir,
>
>> I'm not sure if previous time I sent with or without \0 bugfix. Resending
>
>
> - The function __argp_get_display_len looks very similar to mbsnwidth(),
>   from module 'mbswidth'. Could you use that function? One of the gnulib
>   principles is to reuse code that is already in gnulib, where it makes sense.
Remaining is the issue due to escape sequences.
> - You have shown a test case as a Cyrillic string. But what is the C code
>   to make the behaviour explicit? Could you add this code to 
> tests/test-argp.c,
>   or create a new test file tests/test-argp-3.c?
Done but the test is valid only for UTF-8 locales. Should I force some
specific locale? It's impossible to make a test working in all locales
since in case of e.g. ASCII we don't have such characters at all.


-- 
Regards
Vladimir 'φ-coder/phcoder' Serbinenko

fmtstream.diff
Description: Text Data

signature.asc
Description: OpenPGP digital signature