[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] configmake: correct minor inconsistency in Makefile rule
From: |
Jim Meyering |
Subject: |
[PATCH] configmake: correct minor inconsistency in Makefile rule |
Date: |
Mon, 16 Apr 2012 18:25:02 +0200 |
I noticed a small inconsistency: even with V=0, make would still
echo this command:
mv -f lib/configmake.h-t lib/configmake.h
Every other modules/* snippet did it differently:
$ g grep -B1 mv.-f modules/*
modules/alloca-opt- } > address@hidden && \
modules/alloca-opt: mv -f address@hidden $@
--
modules/argz- } > address@hidden && \
modules/argz: mv -f address@hidden $@
--
modules/byteswap- } > address@hidden && \
modules/byteswap: mv -f address@hidden $@
--
modules/fnmatch- } > address@hidden && \
modules/fnmatch: mv -f address@hidden $@
--
modules/getopt-posix- } > address@hidden && \
modules/getopt-posix: mv -f address@hidden $@
--
modules/glob- } > address@hidden && \
modules/glob: mv -f address@hidden $@
--
modules/poll-h- } > address@hidden && \
modules/poll-h: mv -f address@hidden $@
--
modules/sys_resource- } > address@hidden && \
modules/sys_resource: mv -f address@hidden $@
--
modules/sys_socket- } > address@hidden && \
modules/sys_socket: mv -f address@hidden $@
--
modules/sys_uio- } > address@hidden && \
modules/sys_uio: mv -f address@hidden $@
--
modules/sysexits- } > address@hidden && \
modules/sysexits: mv -f address@hidden $@
This makes configmake's rule consistent:
>From 5a206b3d9b45550b1c4a928cd51deaf1438cb4c8 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 16 Apr 2012 18:22:40 +0200
Subject: [PATCH] configmake: correct minor inconsistency in Makefile rule
* modules/configmake (Makefile.am): All other rules like this one
run the final "mv -f ..." in the same backslash-continued command
as the one that does everything else. This one put the mv -f ...
command on a separate, non-backslash-continued line.
Make it like the others.
---
ChangeLog | 7 +++++++
modules/configmake | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index ebc9b45..8817dab 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2012-04-16 Jim Meyering <address@hidden>
+ configmake: correct minor inconsistency in Makefile rule
+ * modules/configmake (Makefile.am): All other rules like this one
+ run the final "mv -f ..." in the same backslash-continued command
+ as the one that does everything else. This one put the mv -f ...
+ command on a separate, non-backslash-continued line.
+ Make it like the others.
+
bootstrap: use gnulib's po/Makefile.in.in, not the one from gettext
* build-aux/bootstrap: Use gnulib's po/Makefile.in.in, not
the one from gettext. Reported by Akim Demaille.
diff --git a/modules/configmake b/modules/configmake
index 46c0fcc..845e0f4 100644
--- a/modules/configmake
+++ b/modules/configmake
@@ -44,7 +44,7 @@ configmake.h: Makefile
echo '#define PKGINCLUDEDIR "$(pkgincludedir)"'; \
echo '#define PKGLIBDIR "$(pkglibdir)"'; \
echo '#define PKGLIBEXECDIR "$(pkglibexecdir)"'; \
- } | sed '/""/d' > address@hidden
+ } | sed '/""/d' > address@hidden && \
mv -f address@hidden $@
BUILT_SOURCES += configmake.h
--
1.7.10.169.g146fe
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [PATCH] configmake: correct minor inconsistency in Makefile rule,
Jim Meyering <=