[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Doubled word check should be case sensitive

From: Jim Meyering
Subject: Re: Doubled word check should be case sensitive
Date: Thu, 19 Apr 2012 11:43:06 +0200

Reuben Thomas wrote:
> I think this is unhelpful:
> doc/hello.texi:243:for\nFor
> maint.mk: doubled words
> I bet that doubled words typed in error are almost always the same case.
> Differently-cased doubled words are more likely than not to be correct.
> Hence, I suggest removing the "/i" modifier from prohibit_doubled_word_RE_.

I've seen a few false positives like that, too, often due to a
comment saying "in IN" where "IN" refers to a parameter name.
However, I think of that as encouragement to change the name
of the parameter to something a little more descriptive.
I.e., it may look like a false positive, but it's highlighting
an opportunity for improvement.  Your case may be different,
but you didn't show us the context, and I don't have a copy
of gnu hello handy.

I'm pretty sure I added the /i because it exposed a few more
offenders initially, so I'm reluctant to remove it now just
because there are a few false positives.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]