[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix to bootstrap

From: Reuben Thomas
Subject: Re: Fix to bootstrap
Date: Thu, 19 Apr 2012 14:40:46 +0100

On 19 April 2012 14:28, Jim Meyering <address@hidden> wrote:
> Thanks for tracking that down.
> However, rather than handling just that one "cd",
> how about ensuring that no use of "cd" in this script
> can cause such trouble?  To do that, you would unset CDPATH
> somewhere near the top, with a comment explaining its purpose.

That would not deal with "cd -". It also assumes that CDPATH would
never be relied on.

Currently there are two uses of cd in bootstrap, only one of which
(the one I fixed) has its output used.

To make the intention clear, it would seem more sensible to have some
sort of wrapper (function? script?) for cd which never produces
output. Or is that overkill? (Arguably, it's a misfeature of cd.)

Anyway, I leave those more complex issues to you; you can take my fix
for now or adapt it as you see fit.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]