[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] unistd_h: make it easier to avoid sys_types_h

From: Bruno Haible
Subject: Re: [PATCH] unistd_h: make it easier to avoid sys_types_h
Date: Fri, 04 May 2012 23:24:03 +0200
User-agent: KMail/4.7.4 (Linux/3.1.10-1.9-desktop; KDE/4.7.4; x86_64; ; )

Hi Paul,

> This is useful for Emacs, which has its own method of porting to
> Windows, and which therefore does not need the sys_types_h module.

Fine with me. Just that I find the comment in m4/unistd_h.m4 confusing,
because it's not the 'unistd' module which overrides the off_t type, it's
the 'sys_types' module which does.

Are you OK with these comment tweaks?

--- m4/off_t.m4.orig    Fri May  4 23:18:50 2012
+++ m4/off_t.m4 Fri May  4 23:17:46 2012
@@ -1,10 +1,11 @@
-# off_t.m4
+# off_t.m4 serial 1
 dnl Copyright (C) 2012 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
 dnl with or without modifications, as long as this notice is preserved.
 dnl Check whether to override the 'off_t' type.
+dnl Set WINDOWS_64_BIT_OFF_T.
--- m4/unistd_h.m4.orig Fri May  4 23:18:50 2012
+++ m4/unistd_h.m4      Fri May  4 23:15:53 2012
@@ -24,7 +24,7 @@
   dnl Ensure the type pid_t gets defined.
-  dnl Whether to override the 'off_t' type.
+  dnl Determine WINDOWS_64_BIT_OFF_T.
   dnl Check for declarations of anything we want to poison if the

reply via email to

[Prev in Thread] Current Thread [Next in Thread]