bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Comparing binary files with Diff 3.2 compiled with MinGW


From: Eli Zaretskii
Subject: Re: Comparing binary files with Diff 3.2 compiled with MinGW
Date: Sat, 12 May 2012 22:43:08 +0300

> From: Bruno Haible <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Sat, 12 May 2012 20:58:46 +0200
> 
> Eli Zaretskii wrote:
> > > Eli Zaretskii wrote:
> > > > -# if defined __EMX__ || defined __DJGPP__ || defined __CYGWIN__
> > > > +# if defined __EMX__ || defined __DJGPP__ || defined __CYGWIN__ || 
> > > > defined __MINGW32__
> > > >  #  include <io.h> /* declares setmode() */
> > > >  # else
> > > >  #  define setmode _setmode
> > > 
> > > What is the rationale/benefit for this proposed change?
> > 
> > MinGW provides 'setmode' whose declaration is in io.h.
> 
> But mingw's declaration of 'fileno' in stdio.h is not always enabled
> (only if !defined _NO_OLDNAMES).

_NO_OLDNAMES is undefined by default.

> Therefore the #else branch is needed on mingw.

That's okay, but then io.h should be included anyway, because it
provides the prototype of _setmode as well.  According to MSDN, the
same is true for MSVC.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]