[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Comparing binary files with Diff 3.2 compiled with MinGW
|
From: |
Eli Zaretskii |
|
Subject: |
Re: Comparing binary files with Diff 3.2 compiled with MinGW |
|
Date: |
Sun, 13 May 2012 05:52:22 +0300 |
> From: Bruno Haible <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Sat, 12 May 2012 23:28:12 +0200
>
> > (O_TEXT) [!O_BINARY]: Define if not defined.
>
> Why? You don't need it in the diffutils change.
Yes, I do. See this line:
(void) setmode (current->desc, O_TEXT);
> This part is basically OK, but lacks comments and a unit test.
> Here's a proposed patch. It passes all tests on glibc, mingw, MSVC, Cygwin.
Thanks.
- Re: Comparing binary files with Diff 3.2 compiled with MinGW, (continued)
Re: Comparing binary files with Diff 3.2 compiled with MinGW, Bruno Haible, 2012/05/12
Re: Comparing binary files with Diff 3.2 compiled with MinGW, Paul Eggert, 2012/05/12
Re: Comparing binary files with Diff 3.2 compiled with MinGW, Paul Eggert, 2012/05/13
Re: Comparing binary files with Diff 3.2 compiled with MinGW, Bruno Haible, 2012/05/13
Re: Comparing binary files with Diff 3.2 compiled with MinGW, Eric Blake, 2012/05/14