Re: Is IRIX 6.5 obsolete?

[Eric Blake]

On 05/22/2012 06:21 AM, Simon Josefsson wrote:
> Bruno Haible <address@hidden> writes:
> 
>> Hi Simon,
>>
>>> I have reverted the strdup and select patch, and I'll treat
>>> this as a user error.
>>
>> It was a user error. But the select.c patch was good: it fixed an
>> earlier-undetected mistake (that would have likely been a compilation
>> error on Interix).
> 
> However Interix probably made NULL available through the sys/select.h
> header so it worked, assuming someone tested the Interix code.

It may have worked by accident for now, but POSIX doesn't require it to
work, so we are better off using an explicit include that POSIX does
guarantee so that if future Interix ever fixes their headers for POSIX
compliance, we continue to compile.  I say we keep the added #include in
select.c.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature