[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] directory separator
From: |
John Darrington |
Subject: |
Re: [PATCH] directory separator |
Date: |
Thu, 7 Jun 2012 07:19:51 +0000 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Wed, Jun 06, 2012 at 01:07:41PM -0700, Paul Eggert wrote:
On 06/06/2012 12:43 PM, John Darrington wrote:
> If as you say, windows prefers \ is there a good reason NOT to use it?
Mostly to avoid the maintenance hassle.
Surely using a symbol instead of a literal constant makes maintenance easier
not
harder? Especially in this instance where the symbol intended for the purpose
already exists.
Also, the change makes the code a bit bigger and slower
even on non-Windows platforms.
You mean because of the extra printf conversion? If this is of concern, I
could provide an alternative patch which uses string concatenation instead of
a character conversion. Then code and speed would be unaffected.
Regards,
J'
--
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://keys.gnupg.net or any PGP keyserver for public key.
signature.asc
Description: Digital signature