Re: [PATCH] maint.mk: fix VPATH issues

[Jim Meyering]

Akim Demaille wrote:
> There is many small issues with VPATH builds, in the
> release procedure.  A first one.
>
> From c1a33e591861261dcdc9361511835c83c0a22f9c Mon Sep 17 00:00:00 2001
> From: Akim Demaille <address@hidden>
> Date: Thu, 7 Jun 2012 12:21:36 +0200
> Subject: [PATCH] maint.mk: fix VPATH issues.
>
> * top/maint.mk (news-check): GNU Make understand $< very well.
> (release-prep): NEWS is in $(srcdir).
> ---
>  top/maint.mk |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/top/maint.mk b/top/maint.mk
> index 11cb6a6..f0b889b 100644
> --- a/top/maint.mk
> +++ b/top/maint.mk
> @@ -1059,7 +1059,7 @@ sc_makefile_at_at_check:
>         && { echo '$(ME): use $$(...), not @...@' 1>&2; exit 1; } || :
>
>  news-check: NEWS
> -     if sed -n $(news-check-lines-spec)p $(srcdir)/NEWS              \
> +     if sed -n $(news-check-lines-spec)p $<                          \

Thank you!
Changes like this are particularly welcome.

>           | grep -E $(news-check-regexp) >/dev/null; then             \
>         :;                                                            \
>       else                                                            \
> @@ -1367,7 +1367,7 @@ release-prep:
>       fi
>       echo $(VERSION) > $(prev_version_file)
>       $(MAKE) update-NEWS-hash
> -     perl -pi -e '$$. == 3 and print "$(gl_noteworthy_news_)\n\n\n"' NEWS
> +     perl -pi -e '$$. == 3 and print "$(gl_noteworthy_news_)\n\n\n"' 
> $(srcdir)/NEWS

That is fine, too.  Thanks.

You can tell that I rarely run these rules from a non-srcdir
build directory.