Re: new module: relpath

[Eric Blake]

On 06/18/2012 05:38 AM, Akim Demaille wrote:

>>> >> +License:
>>> >> +GPLv3+
>> > 
>> > This module may produce error messages and be under GPL. Then the module
>> > is not usable in shared libraries. If you want a module that is more widely
>> > usable, consider an interface that returns error codes  or error strings,
>> > remove the dependencies to 'error' and 'xalloc', and change the license
>> > to 'LGPL'.
> The attached patch addresses the dependencies on xalloc.  But
> I also notice that canonicalize is not canonicalize-lgpl, and
> there are xallocs in there.  I'm afraid pulling this string
> would lead to much more work than I was ready to invest on this.
> 

>  char *
>  convert_abs_rel (const char *from, const char *target)
>  {
> -  char *realtarget = canonicalize_filename_mode (target, CAN_MISSING);
> -  char *realfrom = canonicalize_filename_mode (from, CAN_MISSING);
> +  char *realtarget = NULL;
> +  char *realfrom = NULL;
> +  char *relative_from = NULL;
> +  char *res = NULL;
> +
> +  realtarget = canonicalize_filename_mode (target, CAN_MISSING);

Indeed, for this to be LGPL, we would have to change
canonicalize_filename_mode() to have a looser license, and I'm not sure
it is a wise idea to attempt that.

-- 
Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature