remove.m4 test (was: Re: Testing 2.16 release candidate with gnulib - quadratic behaviour detected in SSE42 strstr?)

[Bruno Haible]

Carlos O'Donell wrote on libc-alpha:
> http://sourceware.org/glibc/wiki/Testing/Gnulib
> 
> Running the 2.16 release candidate against the gnulib 
> testsuite has turned up three object files being build 
> by gnulib that aren't listed in the known issues:
> 
> (a) logf
> (b) log10f
> (c) remove
> (d) strstr
> ...
> (c) remove
> 
> This function is added automatically.
> 
> e.g.
> ~~~ config.log ~~~
> gl_LIBOBJS=' asnprintf.o chdir-long.o dprintf.o fclose.o fcntl.o fflush.o 
> fprintf.o fpurge.o fseek.o fseeko.o fseterr.o futimens.o glob.o ioctl.o 
> isfinite.o isnand.o isnanf.o isnanl.o linkat.o nanosleep.o openat-proc.o 
> printf.o printf-args.o printf-parse.o remove.o snprintf.o sprintf.o 
> strerror_r.o strstr.o utimensat.o vasnprintf.o vdprintf.o vfprintf.o 
> vprintf.o vsnprintf.o vsprintf.o'
> gl_LTLIBOBJS=' asnprintf.lo chdir-long.lo dprintf.lo fclose.lo fcntl.lo 
> fflush.lo fprintf.lo fpurge.lo fseek.lo fseeko.lo fseterr.lo futimens.lo 
> glob.lo ioctl.lo isfinite.lo isnand.lo isnanf.lo isnanl.lo linkat.lo 
> nanosleep.lo openat-proc.lo printf.lo printf-args.lo printf-parse.lo 
> remove.lo snprintf.lo sprintf.lo strerror_r.lo strstr.lo utimensat.lo 
> vasnprintf.lo vdprintf.lo vfprintf.lo vprintf.lo vsnprintf.lo vsprintf.lo'
> ~~~
> 
> There is no mention of this in the known issues list here:
> http://sourceware.org/glibc/wiki/Testing/Gnulib

Indeed, there is no reason to override the remove() function on glibc
systems. It's a bug that was introduced in a refactoring on 2010-03-20.
Fixed as follows:


2012-06-28  Bruno Haible  <address@hidden>

        remove: No longer override on all platforms. Fixes bug from 2012-03-20.
        * m4/remove.m4 (gl_FUNC_REMOVE): Test gl_cv_func_unlink_honors_slashes,
        not gl_cv_func_unlink_works.
        Reported by Carlos O'Donell <address@hidden>.

--- m4/remove.m4.orig   Thu Jun 28 12:48:13 2012
+++ m4/remove.m4        Thu Jun 28 12:46:32 2012
@@ -1,4 +1,4 @@
-# remove.m4 serial 4
+# remove.m4 serial 5
 dnl Copyright (C) 2009-2012 Free Software Foundation, Inc.
 dnl This file is free software; the Free Software Foundation
 dnl gives unlimited permission to copy and/or distribute it,
@@ -10,7 +10,7 @@
   AC_REQUIRE([gl_STDIO_H_DEFAULTS])
   AC_REQUIRE([gl_FUNC_RMDIR])
   AC_REQUIRE([gl_FUNC_UNLINK])
-  if { case "$gl_cv_func_rmdir_works:$gl_cv_func_unlink_works" in
+  if { case "$gl_cv_func_rmdir_works:$gl_cv_func_unlink_honors_slashes" in
          *yes:*yes) false;;
          *) true;;
        esac