[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootstrap: use a more consistent error reporting scheme.

From: Stefano Lattarini
Subject: Re: [PATCH] bootstrap: use a more consistent error reporting scheme.
Date: Fri, 06 Jul 2012 15:54:32 +0200

On 07/06/2012 03:28 PM, Akim Demaille wrote:
> Le 6 juil. 2012 à 15:21, Stefano Lattarini a écrit :
>> Why not shave off the extra forks here?
>>    printf "$me: $warnf_format_" "$@" >&2
>> This shouldn't cause problems, unless '$me' contains '%' or '\' characters.
> Or end of line.
You mean in one "$@" entry, not in "$me", right?  If yes, point taken.

  Elsewhere, where I use similar routines,
> it is useful to be able to output an error/log message from
> a tool for instance, which may be multiline.
> In that case I prefer to keep the original formatting, but
> prepend the name of the tool on each line.
> That's why I did it this way, but I'll do whatever people here
> tell me to.
I didn't think about the use cases you've described, and they wouldn't
have seemed important *to me*; but if they are to you, please use your
original formulation.  I don't think it's really worth worrying about
performance in this case anyway.  Sure not worth holding this patch


reply via email to

[Prev in Thread] Current Thread [Next in Thread]