bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maint.mk: absolute VPATH build fix


From: Jim Meyering
Subject: Re: maint.mk: absolute VPATH build fix
Date: Sun, 29 Jul 2012 14:02:37 +0200

Akim Demaille wrote:
> Le 29 juil. 2012 à 13:24, Akim Demaille a écrit :
>
>>> I prefer to write it this way, putting the less-likely code in the
>>> indented clause:  (or testing $? != 0)
>>>
>>>       $?
>>>         and die "$ME: $qcmd had unexpected exit code or signal ($?)\n"
>>
>> Hi Jim!
>>
>> Yes, I was annoyed by that too.  Since you allowed the "or die" version,
>> which I much prefer (so you can read consistently expected assertions
>> rather than a mixture of "must be true" and "must be false"), I installed
>> it as follows.
>
> Of course I had to have it wrong in two different ways — I was too eager
> to finally be able to release Bison 2.6.1 :(
>
> I nicely misunderstood what you said to turn it into a way I like ("or die"
> instead of "and die").  So, should I fix it as attached below, or "and die"?

The patch below is fine.

...
> diff --git a/build-aux/gitlog-to-changelog b/build-aux/gitlog-to-changelog
> index 60e1c39..5184edc 100755
> --- a/build-aux/gitlog-to-changelog
> +++ b/build-aux/gitlog-to-changelog
> @@ -210,8 +210,8 @@ sub git_dir_option($)
>        my $git_dir = qx($cmd);
>        defined $git_dir
>          or die "$ME: cannot run $qcmd: $!\n";
> -      $? != 0
> -        or die "$ME: $qcmd had unexpected exit code or signal ($?)\n"
> +      $? == 0
> +        or die "$ME: $qcmd had unexpected exit code or signal ($?)\n";



reply via email to

[Prev in Thread] Current Thread [Next in Thread]