bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maint.mk: absolute VPATH build fix


From: Jim Meyering
Subject: Re: maint.mk: absolute VPATH build fix
Date: Mon, 30 Jul 2012 11:31:42 +0200

Akim Demaille wrote:
> Le 30 juil. 2012 à 09:08, Jim Meyering a écrit :
>
>> Saving the commit message in a variable should do what we want:
>>
>>      msg=$$(emit-commit-log) || exit 1;                              \
>>      (cd $(srcdir) && $(VC) commit -m "$$msg" -a)
>
> Perfect!
>
> Installed as follows.

Thanks!
Reading that, I realized that the explicit sub-shell is no longer
needed, now that the pipe is gone.

>From 6ae8e2b4f83d6fc9e047673ef62b144b511bcbc8 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Mon, 30 Jul 2012 11:30:53 +0200
Subject: [PATCH] maint.mk: avoid a sub-shell

* top/maint.mk (release-prep): Remove unneeded sub-shell.
---
 ChangeLog    | 5 +++++
 top/maint.mk | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index ad0c05b..e72ce70 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2012-07-30  Jim Meyering  <address@hidden>
+
+       maint.mk: avoid a sub-shell
+       * top/maint.mk (release-prep): Remove unneeded sub-shell.
+
 2012-07-30  Akim Demaille  <address@hidden>

        maint.mk: absolute VPATH issue
diff --git a/top/maint.mk b/top/maint.mk
index fa0280e..6336e3a 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -1388,7 +1388,7 @@ release-prep:
        $(MAKE) update-NEWS-hash
        perl -pi -e '$$. == 3 and print "$(gl_noteworthy_news_)\n\n\n"' 
$(srcdir)/NEWS
        msg=$$($(emit-commit-log)) || exit 1;           \
-       (cd $(srcdir) && $(VC) commit -m "$$msg" -a)
+       cd $(srcdir) && $(VC) commit -m "$$msg" -a

 # Override this with e.g., -s $(srcdir)/some_other_name.texi
 # if the default $(PACKAGE)-derived name doesn't apply.
--
1.7.12.rc0.56.g425b8a2



reply via email to

[Prev in Thread] Current Thread [Next in Thread]