[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#12087: Wrong comment in passfd.c?

From: Eric Blake
Subject: Re: bug#12087: Wrong comment in passfd.c?
Date: Mon, 30 Jul 2012 06:24:21 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120717 Thunderbird/14.0

tag 12087 fixed

[adding bug-gnulib, as the source of the bug]

On 07/29/2012 02:14 PM, Jann Horn wrote:
> Hello,
> it looks to me like this comment is wrong:
> gnulib/lib/passfd.c:
> 101 /* recvfd receives a file descriptor through the socket.
> 102    The flags are a bitmask, possibly including O_CLOEXEC (defined in 
> <fcntl.h>).
> 103 
> 104    Return 0 on success, or -1 with errno set in case of error.
> 105 */
> 106 int
> 107 recvfd (int sock, int flags)
> It returns the fd, not 0, on success, right?

You are correct.  Thanks for the report; I've pushed a fix to gnulib.

Coreutils will pick it up on the next gnulib update; but as it is of
minor severity, I'm going to close this coreutils bug report now.  Feel
free to provide further comments!

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]