bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

'_Noreturn' not at beginning of declaration


From: Jim Meyering
Subject: '_Noreturn' not at beginning of declaration
Date: Thu, 23 Aug 2012 22:10:23 +0200

Building coreutils with the latest gcc from git/svn, I see this new failure:

  ./xstrtol.h:69:1: error: '_Noreturn' is not at beginning of declaration \
     [-Werror=old-style-declaration]
   void _Noreturn xstrtol_fatal (enum strtol_error,
   ^

The following fixes it, but I suspect we'll want to
modify m4/stdnoreturn.m4, too, since it also uses
"void _Noreturn" in the test for whether the compiler
provides _Noreturn support.  That test would always fail
when using -Werror=old-style-declaration.

Currently, coreutils is otherwise unaffected, since it doesn't
use the stdnoreturn module, not even indirectly.


>From 6564bc029a14c66233cc182f715bd11effac3187 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Thu, 23 Aug 2012 22:02:39 +0200
Subject: [PATCH] xstrtol.h: avoid "_Noreturn is not at beginning of
 declaration" warning

* lib/xstrtol.h: Put "_Noreturn" before "void" in declaration,
to placate gcc's -Wold-style-declaration.
---
 ChangeLog     | 6 ++++++
 lib/xstrtol.h | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 16b4540..c962a1f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-08-23  Jim Meyering  <address@hidden>
+
+       xstrtol.h: avoid "_Noreturn is not at beginning of declaration" warning
+       * lib/xstrtol.h: Put "_Noreturn" before "void" in declaration,
+       to placate gcc's -Wold-style-declaration.
+
 2012-08-22  Reuben Thomas  <address@hidden>

        pipe-filter: fix comment typo
diff --git a/lib/xstrtol.h b/lib/xstrtol.h
index 516ac56..b0dd122 100644
--- a/lib/xstrtol.h
+++ b/lib/xstrtol.h
@@ -66,7 +66,7 @@ _DECLARE_XSTRTOL (xstrtoull, unsigned long long int)

    After reporting an error, exit with a failure status.  */

-void _Noreturn xstrtol_fatal (enum strtol_error,
+_Noreturn void xstrtol_fatal (enum strtol_error,
                               int, char, struct option const *,
                               char const *);

--
1.7.12.70.g851f7e6



reply via email to

[Prev in Thread] Current Thread [Next in Thread]