[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: maint.mk: improve the release procedure

From: Stefano Lattarini
Subject: Re: maint.mk: improve the release procedure
Date: Tue, 25 Sep 2012 17:25:25 +0200

Hi Akim, Jim.

On 09/25/2012 12:32 PM, Akim Demaille wrote:
> Le 25 sept. 2012 à 12:11, Akim Demaille a écrit :
>>> Pushed.
>> Well, there are several issues with the patch.  I'm on it right now.
>> Do not upgrade gnulib right now.
> Here are the proposed fixes.  I had only tested these patches
> with the various targets of the release procedure, I had not
> anticipated that other targets would be affected.  I have pushed
> an akim-fix-upload branch, which contains the following patch.
> I'll be back in about an hour, feel free to revert the previous
> patches, or install this or a variation thereof.  Sorry about that.
> equal = $(and $(findstring $(1),$(2)),$(findstring $(2),$(1)))
Alas, this is busted for empty strings:

    $ cat Makefile
    equal = ...
    empty1 =
    empty2 =
        $(if $(call equal,$(emtpy1),$(empty2)),:,false)
    $ make
    make: *** [all] Error 1

If you care about such a situation, you'll need this adjustment (or
something similar):

    equal = $(and $(findstring :$(1),:$(2)),$(findstring :$(2),:$(1)))

with which one has:

   $ make


reply via email to

[Prev in Thread] Current Thread [Next in Thread]