bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fstatat.c broken in OpenBSD 4.6


From: Jim Meyering
Subject: Re: fstatat.c broken in OpenBSD 4.6
Date: Sat, 29 Sep 2012 19:16:32 +0200

Mats Erik Andersson wrote:
> some, not too old, change to "lib/fstatat.c" has broken
> the possibility to build that file on OpenBSD 4.6.
>
> The aborting error is
>
>   fstatat.c:26:10: #include expects "FILENAME" or <FILENAME>
>
> Most probably because cpp-3.3.5 is in use. The more recent
> release OpenBSD 5.0 works fine, but Gnulib is broken with
> OpenBSD 4.6 since some time this past Sommer. It is a bad
> idea to demand gcc-4 and newer.

Thanks for the report.
That appears to be due to a typo.
Can you confirm the following fix solves the problem?
I've gone ahead and pushed that, since I don't
see how the old code could have worked.

>From d357bb12e2b267dbd4bdbd96f97851f609b9b4a3 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Sat, 29 Sep 2012 19:13:21 +0200
Subject: [PATCH] fstatat.c: fix a compile-impeding typo

* lib/fstatat.c (FSTATAT_INLINE): Fix typo: s/#include/#define/
Introduced in commit v0.0-7636-gd202279.
---
 ChangeLog     | 6 ++++++
 lib/fstatat.c | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 2905eef..943b881 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2012-09-29  Jim Meyering  <address@hidden>
+
+       fstatat.c: fix a compile-impeding typo
+       * lib/fstatat.c (FSTATAT_INLINE): Fix typo: s/#include/#define/
+       Introduced in commit v0.0-7636-gd202279.
+
 2012-09-28  Akim Demaille  <address@hidden>

        extern-inline: provide a -Wundef safe config.h
diff --git a/lib/fstatat.c b/lib/fstatat.c
index ed42fa8..71b04d5 100644
--- a/lib/fstatat.c
+++ b/lib/fstatat.c
@@ -23,7 +23,7 @@
 #define __need_system_sys_stat_h
 #include <config.h>

-#include FSTATAT_INLINE _GL_EXTERN_INLINE
+#define FSTATAT_INLINE _GL_EXTERN_INLINE

 /* Get the original definition of fstatat.  It might be defined as a macro.  */
 #include <sys/types.h>
--
1.7.12.1.382.gb0576a6



reply via email to

[Prev in Thread] Current Thread [Next in Thread]