[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bug#12793: FORCE_UNSAFE_CONFIGURE=1 - not really a bug, but friendli

From: Eric Blake
Subject: Re: bug#12793: FORCE_UNSAFE_CONFIGURE=1 - not really a bug, but friendliness issue
Date: Mon, 05 Nov 2012 08:12:52 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121016 Thunderbird/16.0.1

[adding gnulib]

On 11/03/2012 10:34 AM, Pádraig Brady wrote:
> On 11/03/2012 02:36 PM, Michael Felt wrote:
>> Would be much nicer if ./configure complained at the beginning about
>> being
>> root, rather than at the end.
> This comes from a specific test in gnulib:
> http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=5c53ef81
> rather than a coreutils policy decision.
> I suppose that check could be hoisted to
> one that is done up front?

We can't directly host the entire test earlier - the test as written
can't detect failure under root until after the C compiler is known
(since it first tests for $? = 99 before checking the environment
variable).  Hoisting the entire test into GL_EARLY means it would come
before the compiler checks, which won't work.

But perhaps we could isolate just the environment variable test to come
first, without regards to the compiler test.  I'll play with that idea.

Eric Blake   address@hidden    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]