bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Patch] Fix build with Android's Bionic for X86


From: Eric Blake
Subject: Re: [Patch] Fix build with Android's Bionic for X86
Date: Tue, 15 Jan 2013 08:28:35 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 01/15/2013 04:02 AM, Andoni Morales wrote:
> Hi,
> 
> The attached patch is a proposed fix to fix building gnulib with
> Android's Binonic for X86 (this bugs does not appear for ARM
> architectures).
> 

> Subject: [PATCH] stdint: fix build with Android's Bionic fox x86
> 
>   * lib/stdint.in.h: fix check to test if included-fixed/sys/types.h
>   was already included as _SSIZE_T_DEFINED_ might also be defined
>   in include/machine/_types.h, which is included by stdio.h
> ---
>  lib/stdint.in.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/stdint.in.h b/lib/stdint.in.h
> index e1108c5..1896015 100644
> --- a/lib/stdint.in.h
> +++ b/lib/stdint.in.h
> @@ -39,7 +39,7 @@
>     Ideally we should test __BIONIC__ here, but it is only defined after
>     <sys/cdefs.h> has been included; hence test __ANDROID__ instead.  */
>  #if defined __ANDROID__ \
> -    && defined _SYS_TYPES_H_ && !defined _SSIZE_T_DEFINED_
> +    && defined _SYS_TYPES_H_ && !defined __need_size_t

Thanks for the patch.  I don't have access to an Android compilation
environment, but as this patch is harmless for all other platforms, and
I trust that it worked for you, I went ahead and pushed it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]