[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs

From: Roland McGrath
Subject: Re: [PATCH] avoid stat/fstat in statvfs/fstatvfs
Date: Thu, 7 Feb 2013 15:37:51 -0800 (PST)

The patch itself now looks fine to me.  The log entry is inadequate.
It needs to mention each file and function touched and say what was
done there.  "Update caller." is sufficient text for a function to
which the only change was trivial argument reordering or whatnot.  But
in most of these cases, each caller dropped a stat* call as well and
so it needs to say "Pass it -1 instead of calling stat64." or suchlike.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]