bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: secure_getenv is broken on FreeBSD.


From: Paul Eggert
Subject: Re: secure_getenv is broken on FreeBSD.
Date: Thu, 07 Feb 2013 22:04:26 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2

On 02/07/2013 02:28 PM, Mats Erik Andersson wrote:
>       ./unistd.h:548: error: expected '=', ',', ';', 'asm' or
>               '__attribute__' before 'extern'

Most likely this has to do with something before the declaration
in question, not being properly terminated or something like that.
It could be many lines earlier.

> Question: How do I test whether _GL_CXXALIAS_SYS is intelligibly
> expanded? The build system stands in my way, making the preprocessed
> intermediaries inaccessible.

Sorry, I don't know how hydra works.  But if you control its inputs,
you could use a modified version of Gnulib that runs gcc -E all
the time, for debugging.

The hydra output did suggest one fix, though.  I pushed the following into
gnulib.  The patch is needed, even if it doesn't fix your bug.
Does it help?

---
 ChangeLog           | 3 +++
 lib/secure_getenv.c | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 4dc8f2c..5439c05 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,8 @@
 2013-02-07  Paul Eggert  <address@hidden>
 
+       secure_getenv: fix include typo
+       * lib/secure_getenv.c: Include config.h.  Somehow I forgot!
+
        secure_getenv: port better to FreeBSD and Solaris
        * lib/secure_getenv.c [!HAVE___SECURE_GETENV]:
        Include unistd.h if HAVE_ISSETUGID, otherwise define a dummy issetugid.
diff --git a/lib/secure_getenv.c b/lib/secure_getenv.c
index 2859522..1fb61bb 100644
--- a/lib/secure_getenv.c
+++ b/lib/secure_getenv.c
@@ -15,6 +15,8 @@
    You should have received a copy of the GNU Lesser General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#include <config.h>
+
 #include <stdlib.h>
 
 #if !HAVE___SECURE_GETENV
-- 
1.7.11.7





reply via email to

[Prev in Thread] Current Thread [Next in Thread]