Re: openpty module broken on Solaris

[Mats Erik Andersson]

fredag den  8 februari 2013 klockan 10:01 skrev Mats Erik Andersson detta:
> The change introduced in gnulib-9fdffff is broken
> on OpenSolaris and Solaris 11.

And OpenBSD.

> The reason is that said patch erroneously leads
> to a claim
> 
>    /* config.h */
>    # define HAVE_OPENPTY 1

It seems to me that this as well as the failure on OpenBSD
is due to the single statement

  ## lib/pty.m4

  AC_CHECK_FUNCS([_getpty posix_openpty],
                 [HAVE_OPENPTY=1], [HAVE_OPENPTY=0])

which jumps the conclusion in setting an macro based on
tests for unrelated function. That these are indeed
unrelated can be gathered from the detected variables
reproduced below. The actual results for "_getpty"
and "posix_openpty" correspond exactly to the
non-desirable override of HAVE_OPENPTY as observed
on Solaris and on OpenBSD.

Best regards,
  Mats Erik Andersson

# FreeBSD 9.0: Succeeds

ac_cv_func__getpty=no
ac_cv_func_posix_openpt=yes
ac_cv_have_decl_posix_openpt=yes
ac_cv_have_decl_openpty=yes

gl_cv_have_raw_decl_posix_openpt=yes
gl_cv_have_raw_decl_openpty=yes

# OpenBSD 5.0: Fails

ac_cv_func__getpty=no
ac_cv_func_posix_openpt=no
ac_cv_have_decl_openpty=yes

gl_cv_have_raw_decl_posix_openpt=no
gl_cv_have_raw_decl_openpty=yes

# OpenSolaris, Solaris 11: Fail

ac_cv_func__getpty=no
ac_cv_func_posix_openpt=yes
ac_cv_have_decl_posix_openpt=yes
ac_cv_have_decl_openpty=no

gl_cv_have_raw_decl_openpty=no
gl_cv_have_raw_decl_posix_openpt=yes