[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] execute: drop dead code

From: Bruno Haible
Subject: Re: [PATCH] execute: drop dead code
Date: Wed, 06 Mar 2013 23:23:50 +0100
User-agent: KMail/4.8.5 (Linux/3.4.11-2.16-desktop; KDE/4.8.5; x86_64; ; )

Hi Eric,

> > Are you OK with this partial revert?
> Sure; that seems reasonable, and also avoids the warning.


> why not just move
> the entire block of code into the one condition where it is used instead
> of going through a complex condition to define it?

I can't move the function definitions into function execute(), and I don't
want to duplicate the 7-lines declaration of execute() either.

I'm committing the change.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]