[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd
From: |
Phillip Susi |
Subject: |
Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd |
Date: |
Wed, 13 Mar 2013 20:59:20 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 03/13/2013 06:55 PM, Paul Eggert wrote:
> No, it's not similar. POSIX says that a double free has undefined
> behavior so an implementation can do what it likes. In contrast,
> POSIX says that fsync (-1) must return -1 and set errno; an
> implementation is not free to do what it likes, and cannot return
> 0.
>
> I don't see this as a major issue. libeatmydata is not a porting
> target for gnulib or for GNU applications in general. If it doesn't
> work, it doesn't work; it's no big deal.
It is a big deal for people trying to accelerate build servers, and
suddenly applications that use gnulib fail to build. Standards are
never followed to the letter. It is gnulib's job to detect variations
and deal with them. Applications are not at all served by failing to
build because some minutia of the posix standard they don't care about
is not followed.
At worst, gnulib should set a flag that applications can check for if
they really depend on this behavior, so that those that don't (
everyone? ) won't fail to build. For that matter, applications that
depend on this really should be testing it at runtime rather than
build time, as the behavior is likely to change.
I would have a lot more sympathy for the notion that gnulib doesn't
want to be bothered by this if this test were actually useful for
anyone, but when nobody really cares about this behavior, it is a
useless test for gnulib to be doing. Complaining about standards
compliance just for standards' sake when it makes no difference either
way is silly.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with undefined - http://www.enigmail.net/
iQEcBAEBAgAGBQJRQSDoAAoJEJrBOlT6nu752MIH+wSf1csaBGoocVC2iKInq2sZ
RREg6VU0b3KRhJrWCeVuN+SvAuxpzdwrsO3U9qhtrsCWgURd4MN4seKi/pjPrmtL
X0TvtrAQEN4tEesDjN1k7Z5fw8+erKVKREsTiGIyPjDD47NN2nhDtUXHevpuBUI3
RV75N/YzEw7vYU5cXviEVdUBYkPW9cGrC99lC76rogwYQeKQ4eHUymKwxzDDezM9
TnZ0f9eJpmSBJcNArgFWPhC/+hWU35eQEgvddoH0cte1z0qYtYm2caEUYQ1ABuke
sPRn09NmLnN4Ji293y6hTXU8XNaqNZgLHklioE1iRhd9ykZQkRNFbwN8ahvfcqM=
=Gcts
-----END PGP SIGNATURE-----
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Eric Blake, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Paul Eggert, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Eric Blake, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Paul Eggert, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd,
Phillip Susi <=
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Eric Blake, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/13
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Paul Eggert, 2013/03/14
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/14
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Paul Eggert, 2013/03/14
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/14
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Eric Blake, 2013/03/14
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Phillip Susi, 2013/03/14
- Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd, Paul Eggert, 2013/03/14