Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/14/2013 12:49 PM, Paul Eggert wrote:
> On 03/14/13 07:24, Phillip Susi wrote:
>>> MIT Kerberos relies on fsync (invalid_fd) returning -1, so I
>>>> suppose it's worth the bother.
>> It does?  How so?
> 
> Just grab the source and grep for 'fsync'; you'll find it checking
> for EBADF afterwards, in at least one place.

Just because it checks for it does not mean that it depends on it.
The question is does it break when run with eatmydata?  Does it break
when built with eatmydata?

A cursory check of the source code indicates that it does not, and the
only way I can see it could in theory is if it regularly tried to
fsync an invalid fd, and would do something bad if it didn't get told
that it had some something stupid ( fsync an invalid fd ).  If not,
then it doesn't depend on it so would not care if gnulib stopped
complaining about it.  For that matter, it doesn't appear to even use
gnulib, so couldn't care one way or the other.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRQgyqAAoJEJrBOlT6nu75fMQH/i096Rs8d6oiZlSOSmX0sDO4
IzkFbiNZsaCAt2hcI2XHl8TLdOzacVd+hdtYbdfe9i1M8WVtrOc2Y9lJQId+hdWh
43ke9/wkDoapWFq/+5cB+d3mr+GOhIG0ptk3SLaN0PyGJ6f+3oO1tAmD4ZENKqJt
4J7ob81HjXEvOGFLM2FySfmqo165q2BilhSleUoZDFJOTpPoc6ZUwW41HrEJEubY
m21j+sivmYw6d1OIDDzjTB7pLpjBkKcaVQAau/W/SkFqSOM/2gf02KeRrwrcbETt
CbQLo2EfcUzlp3YrFSm8OppZ4mMSsJ9odJogSYsaMw8MLw9cAKiP6zI1cOSKKSA=
=vbL+
-----END PGP SIGNATURE-----