Re: Bug: tests/fsync.c: don't check for fsync failure on invalid fd

[Phillip Susi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/14/2013 2:01 PM, Eric Blake wrote:
> You seem to think that just because gnulib's test-fsync fails, that
> the entire package fails.  Really, test-fsync is just a unit test,
> and you are free to ignore its results, when those results are just
> confirming the obvious - that libeatmydata is not POSIX-compliant.

Packages generally do ( and should ) expect the entire test suite to pass.

> It's probably not worth patching gnulib's testsuite to work around 
> libeatmydata, but we have already told you how you may patch 
> libeatmydata to be slightly more friendly to gnulib's testsuite.

It isn't worth having in the first place.  Therefore it is not worth
patching libeatmydata to work around gnulib either.

To be worth changing libeatmydata instead of simply ripping out this
test, something other than the test itself has to care about the
results.  So far it seems this is not the case.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRQh6XAAoJEJrBOlT6nu75WXsIANfzwepZteTuIFgHGz2tdmBS
882uM4xG+MfenZq28FpIIJEBgmdXNT0H2tK7snpjhRxX3MOUBPws3RziEc0G9211
GKiSl63hn3XXlacC5l4rpnOZmbPjNmSXvegoEujFeiIlkQcxlV9MMytM1Wui+w60
NiLC3rFqt/IAqXnZJPk9jR+LarqdHHjC3+s9DGKfqbYAx/Uj43X1fctE49jxnbwb
la6z1pUPC4XQLs0hqzi9osL6byHx+83v6+TAbVzGAh69zUv9eUdjK8EDF5ogl9Vz
1+QNpt/vqp8Gs8N1HiehCpjq1R/kcGsNqIB4/dlLo3jGOvVPBxUoOShz1nrMeqM=
=ukFM
-----END PGP SIGNATURE-----