bug-gnulib
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] regex: test for buffer overrun


From: Dmitry V. Levin
Subject: Re: [PATCH 2/2] regex: test for buffer overrun
Date: Thu, 11 Apr 2013 09:34:34 +0400

On Wed, Apr 10, 2013 at 10:07:09PM -0700, Paul Eggert wrote:
> On 04/10/2013 09:48 PM, Dmitry V. Levin wrote:
> > I think gnulib's tests/test-regex.c should allow glibc's re_search()
> > behavior so that various utilities built --without-included-regex
> > wouldn't be penalized by test-regex:
> 
> This looks like a good idea, thanks; but shouldn't gnulib/m4/regex.m4
> have a similar change?

Indeed.  Since m4/regex.m4 contains a copy of tests/test-regex.c,
it should have this change too.

> Even with the change, utilities built --without-included-regex will
> still report errors with an unpatched glibc because the tests will
> dump core, but I assume that's the intent and that's fine.

Yes.


-- 
ldv

Attachment: pgplqFxlJymMQ.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]