[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] bootstrap: AC_INIT may have up to five fields

From: Sami Kerola
Subject: Re: [PATCH] bootstrap: AC_INIT may have up to five fields
Date: Wed, 8 May 2013 22:22:13 +0100

On 8 May 2013 21:34, Eric Blake <address@hidden> wrote:
> On 05/08/2013 01:33 PM, Sami Kerola wrote:
>> +     /.*,.*,.*,.*,.*,.*/{
> The new regex tries to pick out any script that passes 6 or more
> arguments, which won't exist in practice, so you end up doing the
> fallback to the package name (and the _rest_ of the sed script tries to
> mimic autoconf logic for computing a tarname from the package name).
> What we _really_ want is to reliably pick out the tarname argument if it
> is not empty (hopefully, the package name, version, and bug-report
> fields don't contain quoted commas), so I'm proposing this instead (and
> fixing a non-portable range expression in the meantime):

Hi Eric,

I double checked the change with the sources that earlier blow up at
build, and now all works. Thank you for correcting the patch.

   Sami Kerola

reply via email to

[Prev in Thread] Current Thread [Next in Thread]