Re: Apparent problem with "make web-manual-update"

[Eric Blake]

On 10/10/2013 04:32 AM, Reuben Thomas wrote:
> On 10 October 2013 04:13, Eric Blake <address@hidden> wrote:
> 
>> On 10/09/2013 06:12 PM, Reuben Thomas wrote:
>>> The end of the make log goes:
>>>
>>> test -z ""Hello, GNU World"" \
>>>       && { echo define manual_title in cfg.mk 1>&2; exit 1; } || :
>>> /bin/bash: line 0: test: too many arguments
>>> cd './doc'; \
>>>       /bin/bash ../build-aux/gendocs.sh  \
>>>          -o '/home/rrt/repo/hello/doc/manual' \
>>>          --email address@hidden hello \
>>>         "GNU Hello - "Hello, GNU World""
>>
>> Looks like too many "" in a make variable, such that the shell is
>> getting a different set of arguments than intended.  Should there be
>> some \" in there somewhere?
>>
> 
> Just to be clear, are you suggesting there's something wrong in the input?
> or in the code? (Not quite sure whether you're saying I should be checking
> hello's auto* inputs.)

I'm suggesting that your cfg.mk is flawed.  maint.mk is expanding:

"$(PACKAGE_NAME) - $(manual_title)"

already in double quotes.  If your cfg.mk has:

manual_title="Hello, GNU World"

then that would explain the botched shell command.  Instead, fix your
cfg.mk to have:

manual_title=Hello, GNU World

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature