[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: accommodating OS/x, bleeding edge gcc and warnings

From: Eric Blake
Subject: Re: accommodating OS/x, bleeding edge gcc and warnings
Date: Mon, 28 Oct 2013 14:35:47 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.0

On 10/28/2013 02:16 PM, Eric Blake wrote:
> On 10/19/2013 09:03 PM, Jim Meyering wrote:
>> With very recent gcc and all warnings enabled for grep's subset of
>> gnulib, I was seeing warnings about functions that deserve pure, const
>> and gnu_printf attributes.
>> From 88e5b4d4641f294d8f824d770c9c55a1abe49768 Mon Sep 17 00:00:00 2001
>> From: Jim Meyering <address@hidden>
>> Date: Sat, 12 Oct 2013 19:28:40 -0700
>> Subject: [PATCH 2/2] error: make the module depend on vfprintf-posix
>> * modules/error (Depends-on): Add vfprintf-posix, since error
>> calls vfprintf unconditionally, via error_tail.
> This patch breaks at least libvirt:
> autoreconf: running: aclocal -I m4 --force -I m4
> missing file gnulib/tests/vasnprintf.c
> configure.ac:135: error: expected source file, required through
> AC_LIBSOURCES, not found
> m4/gnulib-comp.m4:518: gl_INIT is expanded from...
> configure.ac:135: the top level
> autom4te: /usr/bin/m4 failed with exit status: 1
> I _think_ the problem is that tests must NOT depend on *printf-posix,
> but I'm still trying to investigate how to fix it.

Given the Comments in vfprintf-posix:
> Comment:
> This module should not be used as a dependency from a test module,
> otherwise when this module occurs as a tests-related module, it will
> have side effects on the compilation of the 'vasnprintf' module, if
> that module occurs among the main modules in lib/.

and the fact that LGPL projects such as libvirt can end up using error
from the testsuite, I'm inclined to revert this patch.  Can you provide
more evidence of why you thought it was necessary, so that we can fix
the real root cause of the problem you encountered without dragging in
vfprintf into the testsuite and corrupting main lib/ clients of
vasnprintf?  See also Paul's recent commit 533101a2, for another
instance of breaking dependencies on a module that has a Comment
prohibiting its use in the testsuite.  Does OS/x lack a vfprintf
function where you ended up with a link failure?  If that's the case, we
should be adding a much simpler LGPL vfprintf module for use by the
error module (rather than dragging in GPL vfprintf-posix).

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]